Fix statusbar corruption #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #126 - Status Bar Corruption
Each current call from Core 0 to
ui_statusbar_update()used the same flags ...UI_UPDATE_ALL.Therefore, changed this to an inter-core message
BP_ICM_FORCE_LCD_UPDATE.Improved
BP_ASSERT_COREx()assertions so that, even in early init, they will print warnings via RTT. This allows early init to ignore these restrictions, but still warns via the debugger in case it causes problems.Added assertions that RX and TX cores are following rules on which core can add/remove items.
These fixes are an important step to fixing other issues (e.g., #167).