Change getRecommendedFriendsBySearch #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daggerpov
approved these changes
Apr 7, 2025
| @Table( | ||
| name = "user", | ||
| indexes = { | ||
| @Index(name = "idx_first_name", columnList = "first_name"), |
| @@ -32,6 +39,8 @@ public class User implements Serializable { | |||
| private String firstName; | |||
| private String lastName; | |||
| private String bio; | |||
|
|
|||
| @Column(nullable = true, unique = true) | |||
There was a problem hiding this comment.
How come this needs to be nullable?
There was a problem hiding this comment.
Due to the App Store requirement for emails, we have to allow users to create accounts without an email
| @@ -210,6 +219,12 @@ private Set<UUID> getExcludedUserIds(UUID userId) { | |||
|
|
|||
| @Override | |||
| public List<BaseUserDTO> searchByQuery(String searchQuery) { | |||
| List<User> users = searchUsersByQuery(searchQuery); | |||
There was a problem hiding this comment.
Hey, could we remove this method and return UserMapper.toDTOList(users) straight from searchUsersByQuery() for simplicity?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR for the existing search endpoint to include results retrieved from the new fuzzy search implementation.