Some dynamic buffer-related clean-up and fixes #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VReaperV
force-pushed
the
cleanup-dynamic-buffers
branch
2 times, most recently
from
5d7425c to
6b1428c
Compare
slipher
reviewed
Feb 5, 2025
| while( glClientWaitSync( rb->syncs[ rb->activeSegment ], GL_SYNC_FLUSH_COMMANDS_BIT, | ||
| 10000000 ) == GL_TIMEOUT_EXPIRED ) { | ||
| Log::Warn("long wait for GL buffer" ); | ||
| // wait until next segment is ready in 10ms intervals |
There was a problem hiding this comment.
Heh, I've seen that warning occasionally. Maybe the timeout should be longer. (non-blocking comment)
There was a problem hiding this comment.
Hmm, I don't think I've ever actually seen that one. I've got some further in-progress changes to these dynamic VBOs/IBOs to fix navedit performance, it might fix the warn too.
These are already inherently a part of `glConfig2.bufferStorageAvailable` and `glConfig2.syncAvailable`, the macros do nothing.
These make no sense when static VBOs are used, so only do those checks if `r_vboModels` is disabled.
VReaperV
force-pushed
the
cleanup-dynamic-buffers
branch
from
6b1428c to
81d27cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r_vboModels. Also changed it to a new-style cvar.