Skip to content

TS artifacts? #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chenglou opened this issue Apr 1, 2025 · 9 comments
Closed

TS artifacts? #10

chenglou opened this issue Apr 1, 2025 · 9 comments

Comments

@chenglou
Copy link

chenglou commented Apr 1, 2025

Hey @DZakh! We’ve been using rescript-schema and need json schema support. But the published builds here don’t include ts files?

@DZakh
Copy link
Owner

DZakh commented Apr 1, 2025

I'm going to move this to be a part of rescript-schema v10. Sorry for keeping you wait for so much good stuff 😅

@DZakh
Copy link
Owner

DZakh commented Apr 1, 2025

If it's urgent. I can release as part of 9.4.0

@chenglou
Copy link
Author

chenglou commented Apr 1, 2025

Oh if it's not too much trouble then yes please!

@DZakh
Copy link
Owner

DZakh commented Apr 2, 2025

I published rescript-json-schema@7.3.0 with a .d.ts file. Could you check that it works? I didn't test it thoroughly.

@DZakh
Copy link
Owner

DZakh commented Apr 4, 2025

@chenglou Pinging you just in case you missed my message.

@chenglou
Copy link
Author

Sorry for the late reply. I'm back from vacations and turns out teammate ended up using zod and zod-to-json-schema for a last-min diff. But now we've converted it back to Sury and re-removed zod =)

Sorry again and thanks a lot!

@DZakh
Copy link
Owner

DZakh commented Apr 24, 2025

Btw, in sury@10.0.0-rc.1 you can use S.toJSONSchema directly from the sury package. The version still has a few failing tests, but it's a very small chance that you'll encounter the issue. Ah, there also might be a problem with error message display in browsers, I'll need to investigate it and fix in rc.1 today or tomorrow 🫡

@DZakh
Copy link
Owner

DZakh commented Apr 24, 2025

Sorry for the late reply. I'm back from vacations and turns out teammate ended up using zod and zod-to-json-schema for a last-min diff. But now we've converted it back to Sury and re-removed zod =)

Sorry again and thanks a lot!

Happy to hear 😁

@DZakh
Copy link
Owner

DZakh commented Apr 24, 2025

False alarm about broken error messages. This was only a Code Sandbox problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants