Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed kTPCDefault to kSimpleThreshold in test_factory.cxx #58

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Changed kTPCDefault to kSimpleThreshold in test_factory.cxx #58

merged 1 commit into from
Feb 22, 2024

Conversation

bieryAtFnal
Copy link
Contributor

@bieryAtFnal bieryAtFnal commented Feb 22, 2024 •
edited
Loading

@bieryAtFnal bieryAtFnal added the miscellaneous deliverable A change that is/will be part of a release but is not substantial enough to be a daq-deliverable label Feb 22, 2024
aeoranday
aeoranday approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@aeoranday aeoranday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There were some changes to the factory implementation that didn't get propagated here, but after applying those changes, the test passes.

@bieryAtFnal bieryAtFnal merged commit 3b72aed into production/v4 Feb 22, 2024
1 check passed
@bieryAtFnal bieryAtFnal deleted the kbiery/addl_changes_for_better_tp_names branch February 22, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeoranday aeoranday aeoranday approved these changes

Assignees
No one assigned
Labels
miscellaneous deliverable A change that is/will be part of a release but is not substantial enough to be a daq-deliverable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bieryAtFnal @aeoranday