Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atypical TXMaker Naming #83

Closed
aeoranday opened this issue Oct 4, 2024 · 1 comment
Closed

Atypical TXMaker Naming #83

aeoranday opened this issue Oct 4, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@aeoranday
Copy link
Member

triggeralgs/src/TAMakerADCSimpleWindowAlgorithm.cpp

Line 12 in b146de1

#define TRACE_NAME "TAMakerADCSimpleWindowAlgorithmPlugin"

All other algorithms follow the naming scheme TXMaker<Brief Name>Algorithm, but this one appends Plugin to the end and should be removed.
@aeoranday aeoranday added the bug Something isn't working label Oct 4, 2024
@aeoranday aeoranday changed the title Atypical Naming Atypical TXMaker Naming Oct 4, 2024
@MRiganSUSX
Copy link
Contributor

Fixed with https://github.com/DUNE-DAQ/triggeralgs/pull/85/files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeoranday @MRiganSUSX