Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a function to translate trigger candidate type to string #50

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

bieryAtFnal
Copy link
Contributor

Also, added a TriggerCandidateData unit test to validate the translations to/from TC types and strings.

This change was made as part of providing the ability to apply different acceptance criteria for different trigger types in automated integration tests (i.e. the integrationtest package data_file_checks).

The simplest way to test these changes is to run the new unit test...

  • create a software area based on a recent nightly build
  • add this repo to that software area and check out the kbiery/get_tc_type_names branch; rebuild the software
  • dbt-build --unittest trgdataformats
  • dbt-unittest-summary.sh

@bieryAtFnal bieryAtFnal requested a review from aeoranday December 3, 2024 15:08
Copy link
Member

@aeoranday aeoranday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bieryAtFnal bieryAtFnal merged commit 600af2a into develop Dec 9, 2024
2 checks passed
@bieryAtFnal bieryAtFnal deleted the kbiery/get_tc_type_names branch December 9, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants