Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed string_to_fragment_type_value to string_to_trigger_candidate_… #47

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

bieryAtFnal
Copy link
Contributor

…type, which seems much more appropriate.

@bieryAtFnal bieryAtFnal marked this pull request as ready for review November 14, 2024 15:01
@bieryAtFnal
Copy link
Contributor Author

bieryAtFnal commented Nov 14, 2024

I've modified this PR so that it is no longer just a draft.

These changes need to be tested (and eventually merged) along with corresponding changes in the trigger and triggeralgs repositories.

Copy link
Contributor

@ArturSztuc ArturSztuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bieryAtFnal bieryAtFnal merged commit be9d99a into develop Nov 14, 2024
2 checks passed
@bieryAtFnal bieryAtFnal deleted the kbiery/tctype_method_rename branch November 14, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants