Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tc types for timing cmd and ssp calib #33

Merged
merged 4 commits into from
Jun 18, 2024
Merged

add tc types for timing cmd and ssp calib #33

merged 4 commits into from
Jun 18, 2024

Conversation

strilov
Copy link

@strilov strilov commented Jun 18, 2024

Checked that the code compiles

@strilov strilov requested review from ArturSztuc and wesketchum June 18, 2024 12:00
@strilov strilov added the miscellaneous deliverable A change that is/will be part of a release but is not substantial enough to be a daq-deliverable label Jun 18, 2024
ArturSztuc
ArturSztuc approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@ArturSztuc ArturSztuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @aeoranday is testing now

@aeoranday aeoranday merged commit a8d058d into patch/fddaq-v4.4.x Jun 18, 2024
@aeoranday aeoranday deleted the feature/ssp_timing_cmd_tc_types branch June 18, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturSztuc ArturSztuc ArturSztuc approved these changes

@wesketchum wesketchum Awaiting requested review from wesketchum

Assignees
No one assigned
Labels
miscellaneous deliverable A change that is/will be part of a release but is not substantial enough to be a daq-deliverable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strilov @ArturSztuc @aeoranday