Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

another attempt at naming the ICEBERG-related TC types #32

Merged
merged 1 commit into from
Jun 18, 2024
Merged

another attempt at naming the ICEBERG-related TC types #32

merged 1 commit into from
Jun 18, 2024

Conversation

bieryAtFnal
Copy link
Contributor

No description provided.

aeoranday
aeoranday approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@aeoranday aeoranday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with CustomTriggerCandidateMaker and shown with tc_dump.py.
image

@bieryAtFnal bieryAtFnal merged commit adffd8d into patch/fddaq-v4.4.x Jun 18, 2024
1 check passed
@bieryAtFnal bieryAtFnal deleted the kbiery/iceberg_tc_types_again branch June 18, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeoranday aeoranday aeoranday approved these changes

@MRiganSUSX MRiganSUSX Awaiting requested review from MRiganSUSX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bieryAtFnal @aeoranday