Enhacements to the data_file_checks that are used to validate data produced in integtests #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use hdf5libs functions instead of basic HDF5 functions.
… use hdf5libs functions
…es by TC type and record ordinal number
work in progress
eflumerf
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary (externally-observable) changes are the addition of support for specifying different expected fragment count and expected fragment size values for records with different TriggerCandidate types and different locations in the raw data files.
A big internal change was the switch from using HDF5 Group and DataSet names to fetch data fragments to using tools provided in hdf5libs.
The changes are backward compatible, in terms of the parameters that we currently specify in our integtests (e.g. daqsystemtest/integtest). However, they depend on changes in the hdf5libs package (PR 111), so they should be tested and merged in conjunction with those.
There is a new markdown document in the "docs" subdirectory that describes a little about the currently-supported parameters for the check_fragment_count() and check_fragment_sizes() functions.