Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use daqconf.set_connectivity_service_port to select the port (or update #87

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Use daqconf.set_connectivity_service_port to select the port (or update #87

merged 2 commits into from
Oct 28, 2024

Conversation

eflumerf
Copy link
Member

if specified in integrationtest config).

Requires DUNE-DAQ/daqconf#530

@eflumerf eflumerf self-assigned this Oct 28, 2024
@eflumerf
Copy link
Member Author

Tested using DUNE-DAQ/daqsystemtest#144

bieryAtFnal
bieryAtFnal approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@bieryAtFnal bieryAtFnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I tested this successfully with the corresponding change in daqconf.

@eflumerf eflumerf merged commit 03226cb into develop Oct 28, 2024
@eflumerf eflumerf deleted the eflumerf/UseDaqconfSetConnectivityServicePort branch October 28, 2024 16:44
@eflumerf eflumerf restored the eflumerf/UseDaqconfSetConnectivityServicePort branch October 29, 2024 13:20
@eflumerf eflumerf deleted the eflumerf/UseDaqconfSetConnectivityServicePort branch October 29, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bieryAtFnal bieryAtFnal bieryAtFnal approved these changes

Assignees

@eflumerf eflumerf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eflumerf @bieryAtFnal