New unit tests for testing lower_bound() and request handling behavior on FD readout types #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pieces function. Still needs some minor mods to get the expected start/end correct when nframe!=1, and additional tests
…equest handler test
…owerBoundAndRequestUnitTests
…adoutRequestHandlers_test.cxx
…owerBoundAndRequestUnitTests
…itions Added the TDEEth data type to FDTypeAdaptersBuffers_test.cxx and FDReadoutRequestHandlers_test.cxx
roland-sipos
approved these changes
Oct 29, 2024
|
@eflumerf and @bieryAtFnal confirmed minimal system quick test is also passing, and DUNE-DAQ/datahandlinglibs#27 has been merged, so I will merge this too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs DUNE-DAQ/datahandlinglibs#27
This adds a new unit test
unittest/FDTypeAdaptersBuffers_test.cxxthat tests lower_bound behavior across a variety of TypeAdapters and Buffers in use in FD readout.I'm starting this as a draft PR to allow for some early review, while I work to prepare a second set of unit tests related to request handlers.
To test, pull down the mentioned datahandlinglibs branch, and then can do