Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use A Special TPG Algorithm Classifier. #229

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

aeoranday
Copy link
Member

I've added a new class whose only function is to interpret the TPG processing steps, their order, and return the algorithm that matches. However, tpglibs has made the algorithms for TPG modular and likely difficult to keep track of, so the matching is very limited to the algorithms that were used in v4.

This was tested in local sessions by varying the processing steps and checking the resultant algorithms with

from trgtools import TPReader
tpr = TPReader(<filename>)
tpr.read_all_fragments()
print(tpr['algorithm'])

Intention is to make readability and potential removal easier in the future.
@aeoranday aeoranday added the enhancement New feature or request label Oct 21, 2024
@aeoranday aeoranday self-assigned this Oct 21, 2024
@aeoranday
Copy link
Member Author

Tested on NP02 and found consistent, working results.

Copy link
Member

@roland-sipos roland-sipos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeoranday aeoranday merged commit c8a5e45 into develop Oct 24, 2024
2 checks passed
@aeoranday aeoranday deleted the aeo/apply-tpg-algorithm branch October 24, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants