v4 New Frame Expansion #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch/fddaq v4.4.x
Patch/fddaq v4.4.x
Does not include the changes to the channel maps calculations.
|
I've added this with target release fddaq-v4.4.8, to enable a stable release that can run TPs on all planes (if we run at a low enough trigger rate). @roland-sipos @alessandrothea , would be good to have you still review and approve this before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the new design for frame expansion as documented here with the resource improvements outlined here.
With the new ability to keep channels in order, there is a step that can be removed from the start that generates a channel map from the first WIBEth frame. This step is not included in this PR, and I have no plans to include this for v4.
This was tested with running on NP04 and viewing the resulting TPs.