Use Modular tpglibs #221
Closed
Use Modular tpglibs #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These preambles should really be restructured.
aeoranday
added
enhancement
This was referenced Aug 30, 2024
|
closing this PR since the branch is included into another PR already (glm/tpglibs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the completion of
tpglibsand it's configuration update, this PR completes the integration. Testing was completed using the test session from https://github.com/DUNE-DAQ/daqconf/wiki/Setting-up-a-dunedaq-v5.1.0-Development-Area with the associated PRs intpglibsandappmodeland verifying the created TPs are consistent before these changes.This PR removes various unused sections, but keeps the
swtpg_wibethlegacy ininclude/fdreadoutlibs/wibeth/tpg.Associated PRs