Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the implementation of TPG thresholding by plane. There are related PRs in daqconf, fddaqconf, and readoutlibs to include the configurables for these thresholds.
By default, the implementation makes use of the general
tpg_threshold
value unless a specific threshold is given forcollection_threshold
,induction2_threshold
, andinduction1_threshold
. These thresholds are then applied according to the plane identification from detchannelmaps.Testing was done with short runs where two of the three planes have a high threshold and the last plane has a low threshold. This was repeated for each of
SimpleThreshold
,AbsRS
, andStandardRS
. Then I checked that the TriggerPrimitives in the generated TPStream were only from the low threshold plane and above the required threshold. The following snippet is the exact check.Testing was consistent for each of the three planes.