You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't know whether to file this Issue in the fdreadoutlibs repo, or the detdataformats repo, or both...
The starting point is that I was printing out information from TriggerPrimitive structures that had been written to disk as part of TriggerRecords, and I noticed that the value of the "detid" field is often (always?) set to one, even when the HD_TPC was being used or emulated. (Recall HD_TPC has Subdetector number 3 in DetID.hh.)
Looking at the TriggerPrimitive.hh file in detdataformats, I see that its "detid" field is not the same thing as detid fields that we have in other places in the code. The TP detid is more of a geographic region.
My first point is that this is rather unfortunate naming. It seems to me that the TP detid field should be called geoid or geoinfo or something that doesn't overlap with a different definition elsewhere in the code.
My second point is that it would be nice to start populating the TP detid field with better values. I see a comment in WIB2FrameProcessor that says something like "to-do: start populating detid with SourceID". I'm not sure that SourceID is the right thing to be using, but it might be better than what is being used now.
I think that it would be great to sort this out and improve the situation, and I'm filing this issue to start the discussion.
The text was updated successfully, but these errors were encountered:
I don't know whether to file this Issue in the
fdreadoutlibs
repo, or thedetdataformats
repo, or both...The starting point is that I was printing out information from TriggerPrimitive structures that had been written to disk as part of TriggerRecords, and I noticed that the value of the "detid" field is often (always?) set to one, even when the HD_TPC was being used or emulated. (Recall HD_TPC has Subdetector number 3 in DetID.hh.)
Looking at the TriggerPrimitive.hh file in
detdataformats
, I see that its "detid" field is not the same thing as detid fields that we have in other places in the code. The TP detid is more of a geographic region.My first point is that this is rather unfortunate naming. It seems to me that the TP detid field should be called geoid or geoinfo or something that doesn't overlap with a different definition elsewhere in the code.
My second point is that it would be nice to start populating the TP detid field with better values. I see a comment in WIB2FrameProcessor that says something like "to-do: start populating detid with SourceID". I'm not sure that SourceID is the right thing to be using, but it might be better than what is being used now.
I think that it would be great to sort this out and improve the situation, and I'm filing this issue to start the discussion.
The text was updated successfully, but these errors were encountered: