Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TriggerPrimitive::detid values seem like they can be improved #85

Open
bieryAtFnal opened this issue Mar 16, 2023 · 0 comments
Open

TriggerPrimitive::detid values seem like they can be improved #85

bieryAtFnal opened this issue Mar 16, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@bieryAtFnal
Copy link
Contributor

I don't know whether to file this Issue in the fdreadoutlibs repo, or the detdataformats repo, or both...

The starting point is that I was printing out information from TriggerPrimitive structures that had been written to disk as part of TriggerRecords, and I noticed that the value of the "detid" field is often (always?) set to one, even when the HD_TPC was being used or emulated. (Recall HD_TPC has Subdetector number 3 in DetID.hh.)

Looking at the TriggerPrimitive.hh file in detdataformats, I see that its "detid" field is not the same thing as detid fields that we have in other places in the code. The TP detid is more of a geographic region.

My first point is that this is rather unfortunate naming. It seems to me that the TP detid field should be called geoid or geoinfo or something that doesn't overlap with a different definition elsewhere in the code.

My second point is that it would be nice to start populating the TP detid field with better values. I see a comment in WIB2FrameProcessor that says something like "to-do: start populating detid with SourceID". I'm not sure that SourceID is the right thing to be using, but it might be better than what is being used now.

I think that it would be great to sort this out and improve the situation, and I'm filing this issue to start the discussion.

@roland-sipos roland-sipos added the enhancement New feature or request label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants