Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threshold By Plane Configurables #35

Merged
merged 4 commits into from
May 14, 2024

Conversation

aeoranday
Copy link
Member

Configurables PR for TPG threshold by plane implementation in fdreadoutlibs. The <plane>_threshold default value of 0 makes that plane's threshold the same as tpg_threshold during runtime.

@aeoranday aeoranday added maintenance Addresses a user request or a change in another part of the system miscellaneous deliverable A change that is/will be part of a release but is not substantial enough to be a daq-deliverable labels May 7, 2024
@aeoranday aeoranday self-assigned this May 7, 2024
@aeoranday
Copy link
Member Author

Latest commit made the word choice changes to match what is used in detchannelmaps. Configs and variables now refer to planes 0, 1, and 2 instead of induction 1, induction 2, and collection. Also prefixed with tpg_.

@aeoranday aeoranday requested a review from alessandrothea May 9, 2024 09:08
@aeoranday aeoranday merged commit 9b00fd8 into patch/fddaq-v4.4.x May 14, 2024
@aeoranday aeoranday deleted the aeo/tpg-threshold-by-plane branch May 14, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Addresses a user request or a change in another part of the system miscellaneous deliverable A change that is/will be part of a release but is not substantial enough to be a daq-deliverable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants