From fa893fadebe33628ee08377cc0b811a45e9bd8e8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EB=8F=84=EA=B2=BD?= Date: Tue, 12 Nov 2024 15:01:07 +0900 Subject: [PATCH] Code migration --- .../service/QueryFloorApplicationService.kt | 9 ++------- .../persistence/AttendancePersistenceAdapter.kt | 17 +++++++++++------ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/main/kotlin/dsm/pick2024/domain/application/service/QueryFloorApplicationService.kt b/src/main/kotlin/dsm/pick2024/domain/application/service/QueryFloorApplicationService.kt index f3f58635..079b40d0 100644 --- a/src/main/kotlin/dsm/pick2024/domain/application/service/QueryFloorApplicationService.kt +++ b/src/main/kotlin/dsm/pick2024/domain/application/service/QueryFloorApplicationService.kt @@ -19,16 +19,11 @@ class QueryFloorApplicationService( @Transactional(readOnly = true) override fun queryFloorAndStatusApplication(floor: Int, status: Status): List { - val today = LocalDate.now().dayOfWeek - val applications = when (floor) { 2, 3, 4 -> { - val filteredClassrooms = if (today == 2 || today == 5) { - queryApplicationPort.queryApplicationWithAttendance(floor) - } else { + val filterClassroomList = queryApplicationPort.findByFloorAndApplicationKind(floor, ApplicationKind.APPLICATION) - } - filteredClassrooms.filter { it.status == status } + filterClassroomList.filter { it.status == status } } 5 -> { queryAllApplicationPort.findAllByStatusAndApplicationKind(status, ApplicationKind.APPLICATION) diff --git a/src/main/kotlin/dsm/pick2024/domain/attendance/persistence/AttendancePersistenceAdapter.kt b/src/main/kotlin/dsm/pick2024/domain/attendance/persistence/AttendancePersistenceAdapter.kt index 7db46ba5..b531c8cf 100644 --- a/src/main/kotlin/dsm/pick2024/domain/attendance/persistence/AttendancePersistenceAdapter.kt +++ b/src/main/kotlin/dsm/pick2024/domain/attendance/persistence/AttendancePersistenceAdapter.kt @@ -28,11 +28,15 @@ class AttendancePersistenceAdapter( override fun findAll() = attendanceJpaRepository.findAll().map { attendanceMapper.toDomain(it) } - override fun findByFloor(floor: Int): List? = attendanceJpaRepository.findByFloor(floor).map { - attendanceMapper.toDomain( - it - ) - } + override fun findByFloor(floor: Int): List? = + jpaQueryFactory + .selectFrom(QAttendanceJpaEntity.attendanceJpaEntity) + .where( + QAttendanceJpaEntity.attendanceJpaEntity.floor.eq(floor), + QAttendanceJpaEntity.attendanceJpaEntity.period6.ne(AttendanceStatus.DROPOUT) + ) + .fetch() + .map { attendanceMapper.toDomain(it) } override fun findByGradeAndClassNum( grade: Int, @@ -41,7 +45,8 @@ class AttendancePersistenceAdapter( .selectFrom(QAttendanceJpaEntity.attendanceJpaEntity) .where( QAttendanceJpaEntity.attendanceJpaEntity.grade.eq(grade), - QAttendanceJpaEntity.attendanceJpaEntity.classNum.eq(classNum) + QAttendanceJpaEntity.attendanceJpaEntity.classNum.eq(classNum), + QAttendanceJpaEntity.attendanceJpaEntity.period6.ne(AttendanceStatus.DROPOUT) ) .fetch() .map { attendanceMapper.toDomain(it) }