Merge pull request #2198 from mitza-oci/cdrfixed

Avoid potential out-of-bounds read in ACE_CDR::Fixed::from_string
DOCGroup · Feb 9, 2024 · 3eb7c03 · 3eb7c03
2 parents f0f11cb + e3d49b9
commit 3eb7c03
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/ACE/ace/CDR_Base.cpp b/ACE/ace/CDR_Base.cpp
@@ -932,7 +932,7 @@ ACE_CDR::Fixed ACE_CDR::Fixed::from_string (const char *str)
       ++f.digits_;
     }
 
-  if (!f.scale_ && str[span - f.digits_ - 1] == '.')
+  if (!f.scale_ && span > f.digits_ && str[span - f.digits_ - 1] == '.')
     f.scale_ = f.digits_;
 
   if (idx >= 0)