Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/week6]: 6주차 필수과제 제출합니다 #14

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kez-lab
Copy link
Member

@kez-lab kez-lab commented Dec 8, 2023

📸 스크린샷

Screen_Recording_20231208-140222_001.mp4

🍀 두런두런

  • 흠... 뭔가 구조를 이쁘게 바꿔보고 싶었는데 더 이상해진 느낌입니다. viewModel에서 Error를 발산하는건 이벤트성이고 valid를 통해 에러를 지우는 건 state를 통해 관리하게 되었는데요,,, 이게 맞는 구조인지 잘 모르겠습니다. 혹시 힌트 좀 주실 분...
  • collectState내에서 계속 뷰가 업데이트되는데 이게 맞을까요 컴포즈에서는 이러지 않았는데... xml로 mvi를 구현하려고 하니까 고민이 많이 됩니다.

Copy link
Member

@Jokwanhee Jokwanhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

상태 관리를 참 잘하시네요.. 매번 코드보고 좋은 부분 배워갑니다 👏

const val ID_MAX_LENGTH = 10
const val PW_MIN_LENGTH = 8
const val PW_MAX_LENGTH = 12
private fun validateField(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI 상태 관리를 직관적으로 잘 나타내신 듯 합니다 굳굳...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 식으로 표현할 수도 있군요.. 코드 보면서 배우는 재미가 있습니당

Copy link
Member

@emjayMJkim emjayMJkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이번 과제도 수고하셨습니다!!

const val ID_MAX_LENGTH = 10
const val PW_MIN_LENGTH = 8
const val PW_MAX_LENGTH = 12
private fun validateField(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 식으로 표현할 수도 있군요.. 코드 보면서 배우는 재미가 있습니당

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants