diff --git a/xds/src/main/java/io/grpc/xds/XdsClientMetricReporterImpl.java b/xds/src/main/java/io/grpc/xds/XdsClientMetricReporterImpl.java index fa88237a7ea..0b592eb019e 100644 --- a/xds/src/main/java/io/grpc/xds/XdsClientMetricReporterImpl.java +++ b/xds/src/main/java/io/grpc/xds/XdsClientMetricReporterImpl.java @@ -90,7 +90,7 @@ final class XdsClientMetricReporterImpl implements XdsClientMetricReporter { Arrays.asList("grpc.target", "grpc.xds.server"), Collections.emptyList(), false); RESOURCES_GAUGE = metricInstrumentRegistry.registerLongGauge("grpc.xds_client.resources", "EXPERIMENTAL. Number of xDS resources.", "{resource}", - Arrays.asList("grpc.target", "grpc.xds.authority", "grpc.xds.cache_state", + Arrays.asList("grpc.target", "grpc.xds.cache_state", "grpc.xds.resource_type"), Collections.emptyList(), false); } diff --git a/xds/src/test/java/io/grpc/xds/XdsClientMetricReporterImplTest.java b/xds/src/test/java/io/grpc/xds/XdsClientMetricReporterImplTest.java index 9ee3f88d921..df5ab87a1c0 100644 --- a/xds/src/test/java/io/grpc/xds/XdsClientMetricReporterImplTest.java +++ b/xds/src/test/java/io/grpc/xds/XdsClientMetricReporterImplTest.java @@ -17,6 +17,7 @@ package io.grpc.xds; import static com.google.common.truth.Truth.assertThat; +import static org.mockito.AdditionalAnswers.delegatesTo; import static org.mockito.ArgumentMatchers.any; import static org.mockito.ArgumentMatchers.argThat; import static org.mockito.ArgumentMatchers.eq; @@ -82,14 +83,14 @@ public class XdsClientMetricReporterImplTest { @Rule public final MockitoRule mocks = MockitoJUnit.rule(); - @Mock - private MetricRecorder mockMetricRecorder; @Mock private XdsClient mockXdsClient; - @Mock - private BatchRecorder mockBatchRecorder; @Captor private ArgumentCaptor gaugeBatchCallbackCaptor; + private MetricRecorder mockMetricRecorder = mock(MetricRecorder.class, + delegatesTo(new MetricRecorderImpl())); + private BatchRecorder mockBatchRecorder = mock(BatchRecorder.class, + delegatesTo(new BatchRecorderImpl())); private XdsClientMetricReporterImpl reporter; @@ -372,6 +373,12 @@ public boolean matches(T instrument) { }); } + static class MetricRecorderImpl implements MetricRecorder { + } + + static class BatchRecorderImpl implements BatchRecorder { + } + static class TestlogHandler extends Handler { List logs = new ArrayList<>();