Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kazakh language option in UI #2316

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Add Kazakh language option in UI #2316

merged 1 commit into from
Jan 24, 2024

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Jan 24, 2024

  • Add kk to language selector dropdown.
  • Fix a bug with {{ _('**a** b')|markdown('default', strip_paragraphs=True) }}.
    • The bug is that p.text could be None, and Python can't add a string to None.

quantum5
quantum5 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@quantum5 quantum5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, why the (seemingly) unrelated change though?

@int-y1
Copy link
Contributor Author

int-y1 commented Jan 24, 2024

the translation for 'proudly powered by **DMOJ**' runs into the bug i mentioned

@quantum5 quantum5 added this pull request to the merge queue Jan 24, 2024
Merged via the queue into DMOJ:master with commit 86c234f Jan 24, 2024
3 checks passed
@int-y1 int-y1 deleted the add-kk branch January 25, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantum5 quantum5 quantum5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@int-y1 @quantum5