Merchant specific BTC Fee Rates #136
Conversation
contracts/DLCManager.sol
Outdated
| if (mintFeeRate == 0 && mintFeeRate != btcMintFeeRate) { | ||
| mintFeeRate = btcMintFeeRate; | ||
| } | ||
| if (redeemFeeRate == 0 && redeemFeeRate != btcRedeemFeeRate) { | ||
| redeemFeeRate = btcRedeemFeeRate; | ||
| } |
There was a problem hiding this comment.
This check is like this because the default value of a mapping is 0. And 0 is a perfectly valid value to set a custom fee rate at. So we check if it has been changed at all.
There was a problem hiding this comment.
Makes sense that you want to handle the initial case of a 0, but i'm not sure this is the right way.
What if we roll this out, then we want to set a merchants fee rate to 0, wouldn't this still then force it to be the global value?
contracts/DLCManager.sol
Outdated
| if (mintFeeRate == 0 && mintFeeRate != btcMintFeeRate) { | ||
| mintFeeRate = btcMintFeeRate; | ||
| } | ||
| if (redeemFeeRate == 0 && redeemFeeRate != btcRedeemFeeRate) { | ||
| redeemFeeRate = btcRedeemFeeRate; | ||
| } |
There was a problem hiding this comment.
Makes sense that you want to handle the initial case of a 0, but i'm not sure this is the right way.
What if we roll this out, then we want to set a merchants fee rate to 0, wouldn't this still then force it to be the global value?
Adds support for setting custom fee rates for a single address.
If there is nothing set, it uses the default global fee rates.