Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getVaultOutputValue function #65

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

Polybius93
Copy link
Collaborator

This PR introduces the getVaultOutputValue function, which retrieves the value of the output directed to the Vault multisig address. Additionally, it updates getVaultFundingBitcoinAddress to ensure it exclusively returns the Funding Address.

Furthermore, it exports several related Bitcoin functions.

scolear
scolear previously approved these changes Feb 11, 2025
Copy link
Contributor

@scolear scolear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more ramda.......

Copy link
Contributor

@scolear scolear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!equals(address, feeRecipientAddress);

clearly better than

address !== feeRecipientAddress;

LGTM i guess

@Polybius93 Polybius93 merged commit e9b6fb5 into main Feb 11, 2025
5 checks passed
@Polybius93 Polybius93 deleted the feat/add-get-vault-output branch February 11, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants