feat: modify uint8array comparing functions

package.json

@@ -1,7 +1,7 @@
 {
   "type": "module",
   "name": "dlc-btc-lib",
-  "version": "1.0.17",
+  "version": "1.0.18",
   "description": "This library provides a comprehensive set of interfaces and functions for minting dlcBTC tokens on supported blockchains.",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

src/functions/bitcoin/bitcoin-functions.ts

@@ -24,7 +24,12 @@ import {
   PaymentTypes,
   UTXO,
 } from '../../models/bitcoin-models.js';
-import { createRangeFromLength, isDefined, isUndefined } from '../../utilities/index.js';
+import {
+  compareUint8Arrays,
+  createRangeFromLength,
+  isDefined,
+  isUndefined,
+} from '../../utilities/index.js';
 
 const TAPROOT_UNSPENDABLE_KEY_HEX =
   '0250929b74c1a04954b78b4b6035e97a5e078a5a0f28ec96d547bfee9ace803ac0';
@@ -428,54 +433,19 @@ export function getValueMatchingOutputFromTransaction(
   return valueMatchingTransactionOutput;
 }
 
-export function validateScript(script: Uint8Array, outputScript: Uint8Array): boolean {
-  return (
-    outputScript.length === script.length &&
-    outputScript.every((value, index) => value === script[index])
-  );
-}
-
 export function getInputIndicesByScript(script: Uint8Array, transaction: Transaction): number[] {
-  const inputIndices: number[] = [];
-
-  createRangeFromLength(transaction.inputsLength).forEach(index => {
+  return createRangeFromLength(transaction.inputsLength).flatMap(index => {
     const inputScript = transaction.getInput(index).witnessUtxo?.script;
-
-    if (!inputScript) {
-      throw new Error('Could not get Input Script');
-    }
-
-    if (
-      inputScript.length === script.length &&
-      inputScript.every((value, index) => value === script[index])
-    ) {
-      inputIndices.push(index);
-    }
+    return inputScript && compareUint8Arrays(inputScript, script) ? [index] : [];
   });
-  return inputIndices;
 }
 
-export function finalizeUserInputs(
-  transaction: Transaction,
-  userPayment: P2TROut | P2Ret
-): Transaction {
-  const userPaymentScript = userPayment.script;
+export function finalizeUserInputs(transaction: Transaction, userPayment: P2TROut | P2Ret): void {
   createRangeFromLength(transaction.inputsLength).forEach(index => {
     const inputScript = transaction.getInput(index).witnessUtxo?.script;
-
-    if (!inputScript) {
-      throw new Error('Could not get Input Script');
-    }
-
-    if (
-      inputScript.length === userPaymentScript.length &&
-      inputScript.every((value, index) => value === userPaymentScript[index])
-    ) {
+    if (inputScript && compareUint8Arrays(inputScript, userPayment.script))
       transaction.finalizeIdx(index);
-    }
   });
-
-  return transaction;
 }
 
 /**

src/proof-of-reserve-handlers/proof-of-reserve-handler.ts

@@ -6,14 +6,14 @@ import {
   deriveUnhardenedPublicKey,
   getUnspendableKeyCommittedToUUID,
   getValueMatchingOutputFromTransaction,
-  validateScript,
 } from '../functions/bitcoin/bitcoin-functions.js';
 import {
   checkBitcoinTransactionConfirmations,
   fetchBitcoinBlockchainBlockHeight,
   fetchBitcoinTransaction,
 } from '../functions/bitcoin/bitcoin-request-functions.js';
 import { RawVault } from '../models/ethereum-models.js';
+import { compareUint8Arrays } from '../utilities/index.js';
 
 export class ProofOfReserveHandler {
   private bitcoinBlockchainAPI: string;
@@ -65,7 +65,7 @@ export class ProofOfReserveHandler {
         this.bitcoinNetwork
       );
 
-      return validateScript(
+      return compareUint8Arrays(
         taprootMultisigPayment.script,
         hex.decode(vaultTransactionOutput.scriptpubkey)
       );

src/utilities/index.ts

@@ -45,6 +45,10 @@ export function isDefined<T>(argument: T | undefined): argument is T {
   return !isUndefined(argument);
 }
 
+export function compareUint8Arrays(a: Uint8Array, b: Uint8Array): boolean {
+  return a.length === b.length && a.every((value, index) => value === b[index]);
+}
+
 export async function delay(ms: number) {
   return new Promise(resolve => setTimeout(resolve, ms));
 }