Improve: Optimize state allocation #479
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of getting this pr merged? |
|
yes, but I would take a different approach. it is good to have your PR as a base to build on though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some optimization to VST3's setState.
This brings massive improvement:
The X axis represents a size of source, and Y axis represents how many bytes are copied by re-allocation (realloc copies buffer right?).
https://docs.google.com/spreadsheets/d/1ELkIF4Xp4o7W6gX1-xuYVYrT0fbgW-AWOC8Z73WU-no/edit?usp=sharing
Closes #478 .
P.S.: The best way is to add entire buffer size as a header, but I didn't so that the effect will be smaller.