Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #151

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update README.md #151

wants to merge 2 commits into from

Conversation

zzunny97
Copy link

@zzunny97 zzunny97 commented Feb 19, 2022 •
edited by andrewchea4
Loading

This PR Fixes DICL/EclipseMETA#(Which issue?)

BRIEF

STATUS

  • Its implemented.
  • It compiles.
  • Its tested.
  • Its refactored.

Make sure that you squeeze all your commits before merging to master.
You might want to use the following command:

$ git rebase -i #hash key of base commit
  • This pull request will release: X.Y.Z

vicentebolea
vicentebolea reviewed Feb 19, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@zzunny97 @vicentebolea
Update README.md
812e9c1 
Co-authored-by: Vicente Bolea <vicente.bolea@gmail.com>
vicentebolea
vicentebolea requested changes Feb 20, 2022
View reviewed changes
Copy link
Member

@vicentebolea vicentebolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just change the commit message before merging this

vicentebolea
vicentebolea approved these changes Feb 20, 2022
View reviewed changes
Copy link
Member

@vicentebolea vicentebolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake nevermind about the commit message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicentebolea vicentebolea vicentebolea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zzunny97 @vicentebolea