Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update provider mentor headers #1379

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Update provider mentor headers #1379

merged 2 commits into from
Feb 11, 2025

Conversation

Kizr
Copy link
Contributor

@Kizr Kizr commented Feb 11, 2025

Context

We don't display the mentor names on the check your answers page for the provider rejection journey.

Changes proposed in this pull request

  • Replace the index of the mentor with their name

Guidance to review

  • Log in as Colin
  • Upload a claim to be audited
  • Reject the claim
  • Assert the the mentor headings in the check your answers page include their names

Link to Trello card

Update rejected by provider copy

Screenshots

image

@Kizr Kizr added the deploy A Review App will be created for PRs with this label label Feb 11, 2025
@Kizr Kizr self-assigned this Feb 11, 2025
@Kizr Kizr requested review from a team as code owners February 11, 2025 17:02
Copy link

github-actions bot commented Feb 11, 2025

Review app track and pay deployed to https://track-and-pay-1379.test.teacherservices.cloud was deleted
Review app school placements deployed to https://manage-school-placements-1379.test.teacherservices.cloud was deleted

Base automatically changed from ba/update-provider-rejection to main February 11, 2025 17:17
@Kizr Kizr merged commit 75b36a7 into main Feb 11, 2025
16 checks passed
@Kizr Kizr deleted the ba/update-provider-mentor-headers branch February 11, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants