Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ethnic background form no method error #10362

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

CatalinVoineag
Copy link
Contributor

Context

Sentry error https://dfe-teacher-services.sentry.io/issues/5774209867/events/66d8e6e0c7964544a0e375e3dfd1f540/

We need to rescue times where the ethnic group passed is not present

Changes proposed in this pull request

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@CatalinVoineag CatalinVoineag self-assigned this Feb 10, 2025
@CatalinVoineag CatalinVoineag marked this pull request as ready for review February 10, 2025 15:49
@CatalinVoineag CatalinVoineag requested a review from a team February 10, 2025 15:50
@CatalinVoineag CatalinVoineag merged commit da92bc6 into main Feb 11, 2025
23 checks passed
@CatalinVoineag CatalinVoineag deleted the cv/fix-ethnic-background-bug branch February 11, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants