Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201] Migrate to OIDC #10358

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

saliceti
Copy link
Member

Context

Changes proposed in this pull request

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@saliceti saliceti added the deploy_v2 Deploy the review app to AKS label Feb 10, 2025
@github-actions github-actions bot temporarily deployed to review-10358 February 10, 2025 11:59 Destroyed
@github-actions github-actions bot temporarily deployed to review-10358 February 10, 2025 12:14 Destroyed
@saliceti
Copy link
Member Author

Testing

@saliceti saliceti force-pushed the 2201-github-actions-oidc-for-all-services branch from a774a63 to aaf8635 Compare February 10, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant