Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deployment 폴더 추가 #46

Merged
merged 2 commits into from
Oct 10, 2024
Merged

deployment 폴더 추가 #46

merged 2 commits into from
Oct 10, 2024

Conversation

wwkler
Copy link
Contributor

@wwkler wwkler commented Oct 9, 2024 •
edited
Loading

이슈번호 : #39
운영 서버를 구현하기 위한 모든 기록을 deployment 폴더에 담아서 추가했습니다.

duri-wip
duri-wip reviewed Oct 9, 2024
View reviewed changes
deployment/Flask/communicate_mlflow.py Outdated



# mlflow Model Registry에 Production Name에 모델의 run id를 가져오는 함수
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석처리된 부분은 삭제해도 될것같습니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

삭제했습니다 감사합니다

duri-wip
duri-wip reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@duri-wip duri-wip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 코드 감사합니다! 주석도 상세히 달아주셔서 이해하기 편했습니다. 테스트 서버와 릴리즈 서버 모두 잘 동작하네요 수고하셨습니다. !! 동일한 파일이 중복되는 부분이 있지만 기능 구현을 위해 어쩔 수 없는 부분 잘 이해했습니다.

@wwkler wwkler merged commit 0e0daaf into DEProjTeam07:master Oct 10, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duri-wip duri-wip duri-wip left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwkler @duri-wip