mhagdorn review #78
Merged
mhagdorn review #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… althernatively we could just drop the second half
|
I've got a number of TODOs in here (tagged with magi) that could do with some feedback/comments. |
Merged
|
@knarrff , there are now two TODOs left when all is merged:
I would suggest that I'll create issues and associated PRs for those two issues after the merge |
knarrff
reviewed
Jan 15, 2025
knarrff
reviewed
Jan 15, 2025
Co-authored-by: Frank Löffler <frank.loeffler@uni-jena.de>
knarrff
reviewed
Jan 15, 2025
Co-authored-by: Frank Löffler <frank.loeffler@uni-jena.de>
Co-authored-by: Frank Löffler <frank.loeffler@uni-jena.de>
knarrff
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for being late to the party and taking some time to work through the manuscript. I have rephrased and clarified a number of sentences. I have also added some comments/todos that could be talked about. Each change is a separate commit which might make it easier to review.