fix: allow chown to fail

DCOR-dev · Dec 12, 2024 · 632a1da · 632a1da
1 parent dcdc827
commit 632a1da
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,5 +1,6 @@
 0.12.1
  - fix: better paths for docker setup
+ - fix: allow chown to fail
 0.12.0
  - feat: add dcor_config.json for docker images
 0.11.8

diff --git a/dcor_control/inspect/common.py b/dcor_control/inspect/common.py
@@ -6,6 +6,7 @@
 import os
 import pwd
 import stat
+import warnings
 
 
 def ask(prompt):
@@ -75,7 +76,11 @@ def check_permission(path: str | pathlib.Path,
             if mode is not None:
                 os.chmod(path, mode)
             if user is not None:
-                os.chown(path, uid, gid)
+                try:
+                    os.chown(path, uid, gid)
+                except BaseException:
+                    warnings.warn(
+                        f"Failed to set ownership '{uid}:{gid}' for '{path}'")
 
     # Check mode
     pmode = stat.S_IMODE(path.stat().st_mode)
@@ -117,8 +122,13 @@ def check_permission(path: str | pathlib.Path,
                 chowner = ask(f"Owner of '{path}' is '{pusr}:{pgrp}', "
                               f"but should be '{user}:{group}'")
             if chowner:
-                did_something += 1
-                os.chown(path, uid, gid)
+                try:
+                    os.chown(path, uid, gid)
+                except BaseException:
+                    warnings.warn(
+                        f"Failed to set ownership '{uid}:{gid}' for '{path}'")
+                else:
+                    did_something += 1
 
     return did_something