Enable RTDC copier to accept list of features #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #247 +/- ##
==========================================
- Coverage 91.27% 91.24% -0.03%
==========================================
Files 115 115
Lines 7848 7856 +8
==========================================
+ Hits 7163 7168 +5
- Misses 685 688 +3 ☔ View full report in Codecov by Sentry. |
paulmueller
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Hi @RaghavaAlajangi Please take a look at the changes I made. The tests did not pass.
|
Dont we need tests for missing lines of code? |
|
Yes, would be good to have them. You up for another PR? |
|
Yes, I will create a new PR with those changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is aimed at enabling
dclab.rtdc_dataset.copierto accept a list of feature strings that can be copied from the source RTDC file to the destination RTDC file.This allows us to include a CLI option to write a specified list of features as mentioned in #246.