Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yank kube support #105

Merged
merged 1 commit into from
Jan 29, 2025
Merged

yank kube support #105

merged 1 commit into from
Jan 29, 2025

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Jan 24, 2025 •
edited
Loading

Before I start killing off dead code warnings, let's get rid of the really dead stuff.

Changes all necessary tests to filespecs, removes an irrelevant test, yanks kube.

Fixes #8

@srhb srhb marked this pull request as draft January 24, 2025 14:27
@srhb srhb marked this pull request as ready for review January 24, 2025 14:44
0z13
0z13 requested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@0z13 0z13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl in devshell still

@0z13
Copy link
Contributor

0z13 commented Jan 27, 2025

rest lgtm

@srhb srhb requested a review from 0z13 January 29, 2025 06:22
@srhb
Copy link
Contributor Author

srhb commented Jan 29, 2025

kubectl in devshell still

@0z13 Thanks, fixed :)

@0z13 0z13 merged commit 688e09b into main Jan 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0z13 0z13 0z13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider yanking kube support?
2 participants
@srhb @0z13