Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully qualify library paths in all tutorials #24

Closed
stevelinberg opened this issue Oct 26, 2022 · 2 comments
Closed

Fully qualify library paths in all tutorials #24

stevelinberg opened this issue Oct 26, 2022 · 2 comments
Assignees
@stevelinberg
Labels
enhancement New feature or request

Comments

@stevelinberg
Copy link
Collaborator

stevelinberg commented Oct 26, 2022 •
edited
Loading

As per the Google style guide, fully qualify all library calls.

equiv.clust -> sna::equiv.clust
@stevelinberg stevelinberg added the enhancement New feature or request label Oct 26, 2022
@stevelinberg stevelinberg self-assigned this Oct 26, 2022
@stevelinberg
Copy link
Collaborator Author

stevelinberg commented Oct 27, 2022 •
edited
Loading

Admittedly, this does make some of the calls a bit cumbersome, as in:

print(karate.ig) -> igraph::print.igraph(karate.ig)

print() needs to become fully qualified to print.igraph() when specified as part of the igraph namespace, as the function for printing in igraph is actually print.igraph(), and print is an S3 generic.

However, it does make it very clear what's happening, whereas just print is vague magic for beginners. I think it's worth the tradeoff.

@stevelinberg
Copy link
Collaborator Author

Broke this out into separate issues for each chapter and support files, issues #26 - #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevelinberg stevelinberg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stevelinberg