Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript generator is generating files with mixed line endings #311

Open
mikoro opened this issue Jul 27, 2024 · 2 comments
Open

TypeScript generator is generating files with mixed line endings #311

mikoro opened this issue Jul 27, 2024 · 2 comments

Comments

@mikoro
Copy link

mikoro commented Jul 27, 2024

It seems that the TypeScript files generated contain mixed line endings. I think the correct approach is to make sure that the source files that are used to generate the output do not have mixed line endings (especially when using @"" multiline strings) and that whenever formatting strings, always use Environment.NewLine.

Copy link
Contributor

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Feb 16, 2025
@filzrev
Copy link
Contributor

filzrev commented Feb 19, 2025

I thought it needs to normalize line ending chars when outputting generated sources.
That similar to Cysharp/ConsoleAppFramework#167

I though generated TypeScript files should use LF as line ending chars.
Because // <auto-generated/> comment supports seems not exists for TypeScript files.
And it might cause .editorconfig/ Linter warnings.

@github-actions github-actions bot removed the stale label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants