1.6 improve version filter #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Alzate <aalzate@sonatype.com>
Signed-off-by: Alex Alzate <aalzate@sonatype.com>
mr-zepol
force-pushed
the
1.6_improve_version_filter
branch
from
dfa8efe to
9344757
Compare
mr-zepol
added a commit
that referenced
this pull request
Apr 2, 2024
Signed-off-by: Alex Alzate <aalzate@sonatype.com>
mr-zepol
added a commit
that referenced
this pull request
Apr 2, 2024
Signed-off-by: Alex Alzate <aalzate@sonatype.com>
mr-zepol
added a commit
that referenced
this pull request
Apr 2, 2024
Signed-off-by: Alex Alzate <aalzate@sonatype.com>
mr-zepol
added a commit
that referenced
this pull request
Apr 7, 2024
Signed-off-by: Alex Alzate <aalzate@sonatype.com>
mr-zepol
added a commit
that referenced
this pull request
Apr 22, 2024
Signed-off-by: Alex Alzate <aalzate@sonatype.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the version filters for the library, it's getting more complex to update every single item in the code when a new element is added in the spec, with this change we only need to add the filter to the new object and the version it was introduced.
NOTE: Tests failing are not related to the changes, this is due to the new schema changes, they will be fixed in the other PRs