Fix pnpm and yarn lock file detection #1643
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix issues described in #1642.
When a pnpm-lock.yaml or yarn.lock files are not present in the root directory cdxgen fails to detect them. This causes cdxgen to try and install dependencies without using the lock file in the first place.
To reproduce on v11.1.8 have a pnpm-lock.yaml file in /frontend and run:
CDXGEN_DEBUG_MODE=debug cdxgen $(pwd)
Cdxgen fails to detect the lock file and tries to install dependencies based on package.json.
Same problem exists for yarn.lock.