[BREAKING] ae.sys.net: Switch to ubyte[]

Rationale:

- See 70d3c53.

Changes required:

- Implementations of the Network class should update their .getFile and
  .post overrides to use ubyte[].

- If necessary, callers should switch to using ubyte[].

sys/net/ae.d

@@ -48,17 +48,17 @@ class AENetwork : Network
 		});
 	} ///
 
-	override void[] getFile(string url)
+	override ubyte[] getFile(string url)
 	{
 		return getData(url).toGC();
 	} ///
 
-	override void[] post(string url, const(void)[] data)
+	override ubyte[] post(string url, const(ubyte)[] data)
 	{
 		Data result;
 		bool got;
 
-		httpPost(url, DataVec(Data(cast(const(ubyte)[])data)), null,
+		httpPost(url, DataVec(Data(data)), null,
 			(Data data) { result = data; got = true; },
 			(string error) { throw new Exception(error); }
 		);

sys/net/cachedcurl.d

@@ -31,6 +31,7 @@ import ae.sys.dataio;
 import ae.sys.dataset;
 import ae.sys.file;
 import ae.sys.net;
+import ae.utils.array;
 import ae.utils.digest;
 import ae.utils.json;
 import ae.utils.time;
@@ -71,7 +72,7 @@ class CachedCurlNetwork : Network
 	{
 		string url; ///
 		HTTP.Method method = HTTP.Method.get; ///
-		const(void)[] data; ///
+		const(ubyte)[] data; ///
 		const(string[2])[] headers; ///
 
 		/// Maximum number of redirects to follow.
@@ -114,10 +115,11 @@ class CachedCurlNetwork : Network
 				};
 			if (request.data)
 			{
-				const(void)[] data = request.data;
+				const(ubyte)[] data = request.data;
 				http.addRequestHeader("Content-Length", data.length.text);
-				http.onSend = (void[] buf)
+				http.onSend = (void[] voidBuf)
 					{
+						auto buf = cast(ubyte[])voidBuf;
 						size_t len = min(buf.length, data.length);
 						buf[0..len] = data[0..len];
 						data = data[len..$];
@@ -179,7 +181,7 @@ class CachedCurlNetwork : Network
 	/// Perform a raw request and return information about the resulting cached response.
 	Response cachedReq(ref const Request request)
 	{
-		auto hash = getDigestString!MD5(request.url ~ cast(char)request.method ~ request.data);
+		auto hash = getDigestString!MD5(request.url.asBytes ~ cast(char)request.method ~ request.data);
 		auto path = buildPath(cacheDir, hash[0..2], hash);
 		ensurePathExists(path);
 		auto metadataPath = path ~ ".metadata";
@@ -190,7 +192,7 @@ class CachedCurlNetwork : Network
 	}
 
 	/// ditto
-	Response cachedReq(string url, HTTP.Method method, const(void)[] data = null)
+	Response cachedReq(string url, HTTP.Method method, const(ubyte)[] data = null)
 	{
 		auto req = Request(url, method, data);
 		return cachedReq(req);
@@ -206,7 +208,7 @@ class CachedCurlNetwork : Network
 		std.file.copy(downloadFile(url), target);
 	} ///
 
-	override void[] getFile(string url)
+	override ubyte[] getFile(string url)
 	{
 		return cachedReq(url, HTTP.Method.get).responseData;
 	} ///
@@ -228,7 +230,7 @@ class CachedCurlNetwork : Network
 				[$-1]);
 	} ///
 
-	override void[] post(string url, const(void)[] data)
+	override ubyte[] post(string url, const(ubyte)[] data)
 	{
 		return cachedReq(url, HTTP.Method.post, data).responseData;
 	} ///

sys/net/curl.d

@@ -35,12 +35,12 @@ class CurlNetwork : Network
 		std.file.write(target, getFile(url));
 	} ///
 
-	override void[] getFile(string url)
+	override ubyte[] getFile(string url)
 	{
 		return get!(AutoProtocol, ubyte)(url);
 	} ///
 
-	override void[] post(string url, const(void)[] data)
+	override ubyte[] post(string url, const(ubyte)[] data)
 	{
 		return .post!ubyte(url, data);
 	} ///

sys/net/package.d

@@ -31,18 +31,18 @@ class Network
 		notImplemented();
 	}
 
-	// TODO: use ubyte[] instead of void[]
+	// TODO: use Data instead of ubyte[]?
 
 	/// Get resource located at the indicated URL.
-	void[] getFile(string url)
+	ubyte[] getFile(string url)
 	{
 		notImplemented();
 		assert(false);
 	}
 
 	/// Post data to the specified URL.
 	// TODO: Content-Type?
-	void[] post(string url, const(void)[] data)
+	ubyte[] post(string url, const(ubyte)[] data)
 	{
 		notImplemented();
 		assert(false);

sys/net/test.d

@@ -20,7 +20,7 @@ import std.process : environment;
 import ae.net.http.common;
 import ae.sys.data : Data;
 import ae.sys.dataset : DataVec, joinToGC;
-import ae.utils.array : asBytes;
+import ae.utils.array : asBytes, as;
 
 static import ae.sys.net.ae;
 static import ae.sys.net.curl;
@@ -75,7 +75,7 @@ void test(string moduleName, string className)()
 
 	debug std.stdio.stderr.writeln(" - post");
 	{
-		auto result = cast(string)net.post(testBaseURL ~ "testUrl4", "Hello world\n");
+		auto result = net.post(testBaseURL ~ "testUrl4", "Hello world\n".asBytes).as!string;
 		assert(result == "Hello world\n", result);
 	}
 

sys/net/wininet.d

@@ -93,7 +93,7 @@ protected:
 		return HNet(hReq);
 	}
 
-	final static void sendRequest(ref HNet hReq, string headers = null, const(void)[] optionalData = null)
+	final static void sendRequest(ref HNet hReq, string headers = null, const(ubyte)[] optionalData = null)
 	{
 		HttpSendRequestA(hReq, headers.ptr, headers.length.to!DWORD, cast(void*)optionalData.ptr, optionalData.length.to!DWORD)
 			.wenforce("HttpSendRequest");
@@ -195,7 +195,7 @@ public:
 		hReq.I!doDownload(&f.rawWrite!ubyte);
 	} ///
 
-	override void[] getFile(string url)
+	override ubyte[] getFile(string url)
 	{
 		auto result = appender!(ubyte[]);
 		auto hNet = open();
@@ -205,7 +205,7 @@ public:
 		return result.data;
 	} ///
 
-	override void[] post(string url, const(void)[] data)
+	override ubyte[] post(string url, const(ubyte)[] data)
 	{
 		auto request = new HttpRequest(url);