Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared Button Added #52

Merged
merged 21 commits into from
Oct 13, 2022
Merged

Shared Button Added #52

merged 21 commits into from
Oct 13, 2022

Conversation

pcabreram1234
Copy link
Contributor

No description provided.

Copy link
Member

@itsalb3rt itsalb3rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please don't change the .env.example file, revert the changes in this file.
  • Remove the package-lock.json, this project uses yarn, no NPM
  • Revert the changes of the src/router/routes.js file, I see some changes of quotes, from single to double.
  • Revert the changes of the quasar.config.js file, I see some changes of quotes, from single to double.

After you make all the changes, I continue testing it.

@pcabreram1234
Copy link
Contributor Author

Chages Done, please check and any issue do not doubt to ask me.

@itsalb3rt
Copy link
Member

itsalb3rt commented Oct 9, 2022

No delete the files, revert each file to the commit with the hash 9666349fd870adfa3f2cb09256a020fe3d1cd81d note the comment and check this doc how to https://dev.to/lofiandcode/git-and-github-how-to-revert-a-single-file-dha

  • Please don't change the .env.example file, revert the changes in this file.
  • Remove the package-lock.json, this project uses yarn, no NPM
  • Revert the changes of the src/router/routes.js file, I see some changes of quotes, from single to double.
  • Revert the changes of the quasar.config.js file, I see some changes of quotes, from single to double.

After you make all the changes, I continue testing it.

@itsalb3rt
Copy link
Member

itsalb3rt commented Oct 9, 2022

I'm testing the functionality and get this error;

image

Others considerations:

  • Add the push prop to the button to following the UI guidelines Frontend sections and guidelines #2
  • Make the Share button float to the right to no leave an empty line between the card container and the photo of the space

@pcabreram1234
Copy link
Contributor Author

It is mandatory to use the Share VueVueSocialSharing Plugin, therefore I have to modify the .quasar/app.js file

The change I have to do is this.

import VueSocialSharing from 'vue-social-sharing'
Vue.use(VueSocialSharing)

And after the line app.use(Quasar, quasarUserOptions)
add this app.use(VueSocialSharing)

Only with this the social media button will works.

exist another way to load this plugin without to modify the .quasar/app.js file ?

I will waiting for your opinion and recomendations

@itsalb3rt
Copy link
Member

VueVueSocialSharing

No problem 😃 , you can import the component in the same file you can use it, for example;

// buttons component
import VueSocialSharing from 'vue-social-sharing'
// others imports and code

{
components: {VueSocialSharing }
}

and now you can use in line component;

<template>
  <VueSocialSharing props... />
</template>

@pcabreram1234
Copy link
Contributor Author

Oh you are rigth, I have forgotten that. I need to practice more VueJs. thanks @itsalb3rt later I will prove this.

@itsalb3rt
Copy link
Member

don't worry Phillip we are here to help 😃

@pcabreram1234
Copy link
Contributor Author

I just made the changes required. Please when you have time review it

@itsalb3rt itsalb3rt merged commit bf067fa into Cowofi:main Oct 13, 2022
@itsalb3rt
Copy link
Member

Thanks @pcabreram1234 I really appreciate this ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants