Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for dex #11

Merged
merged 5 commits into from
Feb 14, 2025
Merged

Add test for dex #11

merged 5 commits into from
Feb 14, 2025

Conversation

masihyeganeh
Copy link

@masihyeganeh masihyeganeh commented Feb 10, 2025

This change is Reviewable

@masihyeganeh masihyeganeh requested review from a team, miladz68 and ysv and removed request for a team February 10, 2025 10:25
Copy link

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ysv)


packages/test-tube/Cargo.toml line 7 at r1 (raw file):

name = "test-tube-coreum"
repository = "https://github.com/CoreumFoundation/test-tube"
version = "5.0.0"

same as above


packages/coreum-test-tube/Cargo.toml line 7 at r1 (raw file):

repository = "https://github.com/CoreumFoundation/test-tube"
name = "coreum-test-tube"
version = "5.0.0"

let's call it 5.0.0-rc or masater to avoid confusion


packages/coreum-test-tube/Cargo.toml line 19 at r1 (raw file):

serde = "1.0.203"
serde_json = "1.0.117"
test-tube-coreum = { version = "5.0.0", path = "../test-tube" }

same as above

Copy link
Author

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 11 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @miladz68 and @ysv)


packages/coreum-test-tube/Cargo.toml line 7 at r1 (raw file):

Previously, miladz68 (milad) wrote…

let's call it 5.0.0-rc or masater to avoid confusion

Done.


packages/coreum-test-tube/Cargo.toml line 19 at r1 (raw file):

Previously, miladz68 (milad) wrote…

same as above

Done.


packages/test-tube/Cargo.toml line 7 at r1 (raw file):

Previously, miladz68 (milad) wrote…

same as above

Done.

@ysv ysv requested a review from miladz68 February 12, 2025 14:15
Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 11 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @miladz68)

Copy link

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

@masihyeganeh masihyeganeh merged commit 8a2f299 into main Feb 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants