-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for dex #11
Add test for dex #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ysv)
packages/test-tube/Cargo.toml
line 7 at r1 (raw file):
name = "test-tube-coreum" repository = "https://github.com/CoreumFoundation/test-tube" version = "5.0.0"
same as above
packages/coreum-test-tube/Cargo.toml
line 7 at r1 (raw file):
repository = "https://github.com/CoreumFoundation/test-tube" name = "coreum-test-tube" version = "5.0.0"
let's call it 5.0.0-rc
or masater
to avoid confusion
packages/coreum-test-tube/Cargo.toml
line 19 at r1 (raw file):
serde = "1.0.203" serde_json = "1.0.117" test-tube-coreum = { version = "5.0.0", path = "../test-tube" }
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 11 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @miladz68 and @ysv)
packages/coreum-test-tube/Cargo.toml
line 7 at r1 (raw file):
Previously, miladz68 (milad) wrote…
let's call it
5.0.0-rc
ormasater
to avoid confusion
Done.
packages/coreum-test-tube/Cargo.toml
line 19 at r1 (raw file):
Previously, miladz68 (milad) wrote…
same as above
Done.
packages/test-tube/Cargo.toml
line 7 at r1 (raw file):
Previously, miladz68 (milad) wrote…
same as above
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 11 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @miladz68)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)