Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add JsonCanonicalizer and use in serialization #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add JsonCanonicalizer and use in serialization #5

wants to merge 2 commits into from

Conversation

scasplte2
Copy link
Collaborator

Changes

  • Simplifies JsonBinaryCodec to be derived from Encoder / Decoder instances
  • Introduces JsonCanonicalizer to create a stable Json => String mapping for use in crypto ops (RFC 8785)
  • Refactor the process for hashing via JsonBinaryHasher that relies on the derived JsonBinaryCodec which in turn uses the JsonCanonicalizer to get the bytes for hashing
  • Refactors the MetagraphCommonService use derived binary codec
  • Removed unnecessary typeclass definitions in lieu of derived instances for the binary codec

Testing

  • Added JsonBinaryHasherSuite
  • Added JsonBinaryCodecSuite
  • Added JsonCanonicalizerSuite

@scasplte2 scasplte2 changed the title fix: update contributors to reference github feat: add JsonCanonicalizer and use in serialization Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gclaramunt gclaramunt Awaiting requested review from gclaramunt

@marcinwadon marcinwadon Awaiting requested review from marcinwadon

@kpudlik kpudlik Awaiting requested review from kpudlik

@IPadawans IPadawans Awaiting requested review from IPadawans

@ryle-goehausen ryle-goehausen Awaiting requested review from ryle-goehausen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@scasplte2