Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node.js test suite with a reasonable degree of coverage #18

Closed
rudokemper opened this issue Feb 1, 2024 · 1 comment
Closed

Add Node.js test suite with a reasonable degree of coverage #18

rudokemper opened this issue Feb 1, 2024 · 1 comment

Comments

@rudokemper
Copy link
Member

rudokemper commented Feb 1, 2024

Feature Request

This PR added some automated tests via Dockerhub, but we should have a basic Node.js test suite as well.

User Stories & Acceptance Criteria

Get tests working with each of the fixtures in tests/fixtures, and the online services.
Add unit tests for any function likely to run into edge cases, and a few integration tests.

  • downloadOnlineTiles
  • generateStyle
  • generateJPG
  • generateMBTiles - with fixtures, with an online service, with overlay
  • renderTile

Implementation Plan

There might be some tests and fixtures that we can use from mbgl-renderer, albeit that those are largely focused on static image outputs.

@rudokemper
Copy link
Member Author

#23 added the framework but I want to keep this issue open as a reminder to add more tests coverage.

@rudokemper rudokemper changed the title Add basic Node.js test suite Add Node.js test suite with a reasonable degree of coverage Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant