Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drafted goerli deneb network change #7853

Closed
wants to merge 1 commit into from

Conversation

rolfyone
Copy link
Contributor

The pr was missing some config I think, I had to add a bunch of Deneb fields that were flagged missing in tests.

Ref. eth-clients/goerli#178

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

The pr was missing some config I think, I had to add a bunch of Deneb fields that were flagged missing in tests.

Ref. eth-clients/goerli#178

Signed-off-by: Paul Harris <paul.harris@consensys.net>
@rolfyone rolfyone marked this pull request as ready for review January 2, 2024 05:51
Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add

.trustedSetupFromClasspath(MAINNET_TRUSTED_SETUP_FILENAME) to the Eth2NetworkConfiguration section for goerli

@StefanBratanov
Copy link
Contributor

superceeded by #7857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants