Refac/groth16 mpc

[Tabaie]

Description

#1297, but using tools from Consensys/gnark-crypto#589.

Fixes # (issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How has this been tested?

• Test A
• Test B

How has this been benchmarked?

• Benchmark A, on Macbook pro M1, 32GB RAM
• Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I did not modify files generated from templates
• golangci-lint does not output errors locally
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[gbotrel]

lgtm, minor changes maybe

[ivokub]

Thanks Arya! It looks really nice. Imo I understood it mostly. There are a few comments though, see inline.

A few of the comments are nice to have and you don't need to address now. We could do it in separate PR:

• optional randomness source for contribution
• being able to change hash function for challenge computation for cool tricks a la providing SNARK of ceremony correctness

[Tabaie]

Thanks Arya! It looks really nice. Imo I understood it mostly. There are a few comments though, see inline.

A few of the comments are nice to have and you don't need to address now. We could do it in separate PR:

• optional randomness source for contribution
• being able to change hash function for challenge computation for cool tricks a la providing SNARK of ceremony correctness

These are great ideas! I made an issue for them.