Feat/switch groth16 key #1357
Open
Feat/switch groth16 key #1357
+945
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bit behind on reviews and will get to it soon |
ivokub
force-pushed
the
feat/switch-groth16-key
branch
from
6ffa023 to
4e1aa27
Compare
I rebased on top of master and fixed conflicting changes. I'll still have a look at the Groth16 test and add tests for MuxG2/MuxGt. And I'd like to write documentation example. But in general looks good. |
|
Super nice!!
|
Co-authored-by: Ivo Kubjas <ivo.kubjas@consensys.net>
This reverts commit b04a688. Build fails when dependencies not installed.
…ensys#1352) Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
Co-authored-by: Ivo Kubjas <ivo.kubjas@consensys.net>
Signed-off-by: wangjingcun <wangjingcun@aliyun.com>
Signed-off-by: hishope <csqiye@126.com>
…nsys#1338) Signed-off-by: ChengenH <hce19970702@gmail.com>
Co-authored-by: Gautam Botrel <gautam.botrel@gmail.com>
…nsensys#1364) Co-authored-by: Gautam Botrel <gautam.botrel@gmail.com>
Co-authored-by: Ivo Kubjas <ivo.kubjas@consensys.net>
Signed-off-by: linchizhen <jiayanbing@yeah.net>
Co-authored-by: Arya Tabaie <15056835+Tabaie@users.noreply.github.com>
Co-authored-by: Youssef El Housni <youssef.elhousni@consensys.net>
…sensys#1365) Co-authored-by: Ivo Kubjas <ivo.kubjas@consensys.net>
Signed-off-by: oliveredget <188809800+oliveredget@users.noreply.github.com> Signed-off-by: dashangcun <907225865@qq.com> Signed-off-by: zhuhaicity <zhuhai@52it.net> Signed-off-by: hidewrong <hidewrong@outlook.com> Co-authored-by: oliveredget <188809800+oliveredget@users.noreply.github.com> Co-authored-by: dashangcun <907225865@qq.com> Co-authored-by: ZhuHaiCheng <zhuhai@52it.net> Co-authored-by: hidewrong <hidewrong@outlook.com> Co-authored-by: VolodymyrBg <aqdrgg19@gmail.com>
lucasmenendez
force-pushed
the
feat/switch-groth16-key
branch
from
1f67b21 to
59fb979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
SwitchVerificationKeyfor groth16 recursion. By including two verification keys for similar circuits, it allows recursive verification of multiple proofs for both circuits, seamlessly switching between their corresponding verification keys as needed.Type of change
How has this been tested?
There are three similar tests that verify that two proofs from two different circuits are in the third circuit. Each test uses different curves for the inner and outer circuits:
TestMultipleBN254InBN254TestMultipleBLS12InBW6TestMultipleBW6InBN254Checklist:
golangci-lintdoes not output errors locally