Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/GW-1542/header-refactor #94

Merged
merged 13 commits into from
Dec 5, 2023
Merged

feature/GW-1542/header-refactor #94

merged 13 commits into from
Dec 5, 2023

Conversation

remko48
Copy link
Member

@remko48 remko48 commented Dec 1, 2023

No description provided.

lencodes
lencodes suggested changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@lencodes lencodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes @remko48, I've left some comments.

pwa/src/layout/Layout.tsx Outdated Show resolved Hide resolved
pwa/src/hooks/useHeaderTopNavItems.ts Outdated Show resolved Hide resolved
pwa/src/hooks/useHeaderTopNavItems.ts Outdated Show resolved Hide resolved
@remko48 remko48 requested a review from lencodes December 5, 2023 15:04
lencodes
lencodes approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@lencodes lencodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏼

@remko48 remko48 merged commit 3523692 into development Dec 5, 2023
2 checks passed
@remko48 remko48 deleted the feature/GW-1542/header-refactor branch December 5, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lencodes lencodes lencodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remko48 @lencodes